D8479: Fix viewport on vertically stacked monitors

David Edmundson noreply at phabricator.kde.org
Wed Oct 25 17:14:10 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  We want to translate by the monitor position, so that needs to be
  the negative of the position.
  
  But Kwin/KScreen treats 0 as the top of all monitors. GL treats 0 as
  bottom, so that all needs inverting.
  
  Hence this should be a positive y value for the viewport.
  
  BUG: 386099

TEST PLAN
  Had two monitors
  Side by side was - fine 
  Stacked vertically - still fine
  
  Modded X code to extend in y instead of x.
  3 monitors worked fine.
  
  Nested wayland only seems to support one screen?

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8479

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/x11/windowed/egl_x11_backend.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/d536b6ce/attachment.html>


More information about the Plasma-devel mailing list