D8473: Modernize code. Use nullptr where it's possible

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 25 15:47:31 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> mimetypesmodel.cpp:109
>  {
> -    for (int i = 0; i < m_mimeTypesList.size(); i++) {
> +    for (int i = 0, total = m_mimeTypesList.size(); i < total; ++i) {
>          if (m_mimeTypesList.at(i).name() == name) {

Isn't the compiler smart ehough?

> previewpluginsmodel.cpp:112
>      QStringList list;
> -    for (int i =0; i < m_checkedRows.size(); ++i) {
> +    for (int i =0, total = m_checkedRows.size(); i < total; ++i) {
>          if (m_checkedRows.at(i)) {

Space after `=`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8473

To: mlaurent, hein
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/d8659cfd/attachment.html>


More information about the Plasma-devel mailing list