D8447: Add unit tests for Folder View

Eike Hein noreply at phabricator.kde.org
Wed Oct 25 08:35:53 UTC 2017


hein accepted this revision.
hein added a comment.


  Thanks for working on this! We really need better test coverage in Plasma bits.
  
  I'm a little bit unhappy about littering headers with FOLDERPLUGIN_TESTS_EXPORT, but I guess it's the lesser evil of statically linking and building the code twice.
  
  The tests itself look like a good start.
  
  (Aside: If you have bigger plans for upcoming FV contributions, it'd be cool to sit down on IRC and talk a bit. I had a long conversation with Milian last month, I guess/hope he passed that info on.)

REVISION DETAIL
  https://phabricator.kde.org/D8447

To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/c6702c66/attachment.html>


More information about the Plasma-devel mailing list