D8402: Support "domain-suffix-match" in Security8021xSetting

[Jan Grulich]

jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> security8021xsetting.h:66
>  
> +    void setDomain(const QString &domain);
> +    QString domain() const;

Usually these methods are named according to property they return so in this case it should be setDomainSuffixMatch() and domainSuffixMatch().  Same applies to other places where you use just domain.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171023/be9904ab/attachment-0001.html>