D8424: Folder View location properties: Improve visual layout

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current appearance of this dialogue:
  
  F5443493: folderview-properties-location_BEFORE.png <https://phabricator.kde.org/F5443493>
  
  has a number of visual anomalies:  most significantly, the spacing and alignment between the 3rd/4th radio buttons and their text is not the same as the 1st/2nd buttons.  Not only is the visual appearance different but also the operation:  the 1st/2nd buttons can be selected by clicking on the label in addition to the button, so increasing the target area, but the 3rd/4th can only be clicked on the actual button.  Also, the group box titles ("Location" and "Title"), with no visual distinction and indented a long way, are not obvious for being group titles.
  
  The revised layout:
  
  F5443501: folderview-properties-location_AFTER.png <https://phabricator.kde.org/F5443501>
  
  uses a single grid layout, so aligning all of the combo boxes and entry fields.  All four radio buttons have text, so they are able to be selected by clicking on the text.

TEST PLAN
  Built plasma-desktop with this change.  Checked appearance and operation both as a desktop containment (when the "Title" controls do not appear) and as a standalone plasmoid (when they do).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8424

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171022/64977528/attachment.html>