D8399: Fix colours not updating in systemsettings
David Edmundson
noreply at phabricator.kde.org
Sat Oct 21 14:05:06 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
(after a log of looking, it turns it's out not a bug in the QQC desktop
style)
KSharedConfig::openConfig() opens the config based on the app name.
The app name comes from the exec name, or
KAboutData::setApplicationData.
setApplicationData only works on an existing qApp.
This means the QPT loaded in the QApp uses the wrong config.
The effect is minimal because most stuff is in kdeglobals, but it means
the KSharedConfigPtr is not shared with the one used elsewhere in the
app. This is wasteful, but also means the QPT calling
reparseConfiguration doesn't take effect, leading to colours not being
dynamically updated
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8399
AFFECTED FILES
app/main.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171021/b5217625/attachment.html>
More information about the Plasma-devel
mailing list