D8358: Use QActions directly in menu

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 18 13:37:44 UTC 2017


broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of duplicating the name and icon work, just bind it to the QAction itself. Also respect visibility of actions for KIOSK restriction.

TEST PLAN
  It now uses System Settings app icon for "About System Settings" instead of "help-about", though.
  Placed the following in kdeglobals
  
    [KDE Action Restrictions]
    action/configure=false
  
  Action would no longer show up. It would never trigger as the action was disabled internally so this is purely cosmetic.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8358

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171018/25a3772f/attachment.html>


More information about the Plasma-devel mailing list