D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments
Chris Holland
noreply at phabricator.kde.org
Mon Oct 16 00:59:09 UTC 2017
Zren created this revision.
Zren added a reviewer: ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
First I fixed the ActionItem label width exiting the button boundaries mentioned in https://bugs.kde.org/show_bug.cgi?id=385794
Example of the bug:
F5432216: 2017-10-15___17-02-08.png <https://phabricator.kde.org/F5432216>
Since We cutoff the ActionItem text, I then changed the minimum width to 300px since it fits the *english* text naturally.
F5432215: 2017-10-15___20-40-47.png <https://phabricator.kde.org/F5432215>
I could probably change that to preferredWidth=300px (with minimumWidth=200px) if you want a desktop widget to start at 200px width, but a "panel widget" open as 300px. A systemtray widget is always ~400x330px.
I also multiplied the minimum widget size so it scales with the DPI.
You can test with:
QT_DEVICE_PIXEL_RATIO=2 plasmoidviewer -a package
Lastly, I added my commented out mockup of the `vaultsModel` since `plasmoidviewer` doesn't expose vault's `plasmoid.nativeInterface`. If you won't use this then I'll remove it.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8324
AFFECTED FILES
plasma/package/contents/ui/ActionItem.qml
plasma/package/contents/ui/main.qml
To: Zren, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171016/529d9ea8/attachment.html>
More information about the Plasma-devel
mailing list