D8309: Modernize: Use nullptr where possible

Kevin Funk noreply at phabricator.kde.org
Sun Oct 15 16:44:53 UTC 2017


kfunk marked an inline comment as done.
kfunk added inline comments.

INLINE COMMENTS

> broulik wrote in backtracegenerator.cpp:69
> `Q_ASSERT(!m_proc && !m_temp)`?
> iirc Clang doesn't like comparisons to `nullptr` very much (at least in `QCOMPARE`) and I find it cleaner

That can't be problem. This code will compile fine.

`QCOMPARE(a,nullptr)` since this is triggering some template instantiations which might fail to deduce the correct pointer type for the rhs.

Fixed it anyhow :)

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8309

To: kfunk, sitter, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171015/706fd036/attachment.html>


More information about the Plasma-devel mailing list