D8307: Make Qt5::X11Extras really optional

René J.V. Bertin noreply at phabricator.kde.org
Sun Oct 15 15:47:48 UTC 2017


rjvbb added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:32
> Is this change needed?

I don't understand, since when has DrKonqi been split out of plasma-runtime?

Plasma-runtime had a different approach: search for X11Extras only when X11 was found. I think that's the better approach; keep it obligatory with X11 (if there's a reason for that), don't bother to look for it when building for another platform.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8307

To: kfunk, rjvbb, sitter, davidedmundson
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171015/25659089/attachment.html>


More information about the Plasma-devel mailing list