D8258: [Task Tools] Treat applications: and respective absolute path equal in launcherUrlsMatch

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> tasktools.cpp:616
>  
>  bool launcherUrlsMatch(const QUrl &a, const QUrl &b, UrlComparisonMode mode)
>  {

launcherUrslMatch is in a somewhat hot path that is called a lot.

If we have to do this, fine, but if there's an alternative; such as resolving the launcher to a KService (KService::serviceByMenuId) once in the launcher, that would be IMHO much much better.

---

Also menuId is built from the filename; (vfolder_menu.cpp:947) (prefix in that line is empty for anything non-supersuper-legacy)

Is there a reason we can't just compare filenames here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8258

To: broulik, #plasma, hein, ngraham, mvourlakos
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171013/45f676f8/attachment.html>