D8178: Fix editing items in SimpleFavoritesModel

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> ivan wrote in tools.js:185
> I don't like this change. Would rather have this stated explicitly than rely on the implementation in the favmodel. Can you make this part also aware of which model is behind the favoriteModel variable?

With yet another ```_kicker_favorite_remove_from_any``` method? I did a search for removeFavorite and it's not used outside of this file, so the API should be as minimal as possible IMO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8178

To: fvogt, #plasma, davidedmundson
Cc: ivan, hein, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171012/6191c174/attachment.html>