D8178: Fix editing items in SimpleFavoritesModel

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> tools.js:185
>          console.log("Removing from all activities");
> -        favoriteModel.removeFavoriteFrom(favoriteId, ":any");
> -
> +        favoriteModel.removeFavorite(favoriteId);
>      } else if (actionId == "_kicker_favorite_add") {

I don't like this change. Would rather have this stated explicitly than rely on the implementation in the favmodel. Can you make this part also aware of which model is behind the favoriteModel variable?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8178

To: fvogt, #plasma, davidedmundson
Cc: ivan, hein, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171011/4775ec26/attachment.html>