D8159: Add API for setting server decoration palettes

[Martin Flöser]

graesslin added a comment.


  I'm fine with the change, but when I thought about it, I was wondering whether it would be better to have a dedicated interface. There is at least one other Wayland compositor out there which implements the protocol and I got several requests about upstreaming it. So if at some day it ends up in wayland-protocols I think this request would be too Plasma/KWin specific with a reference to the KColorScheme path. On the other hand one can consider it a point for future as we have to change the code anyway if it ever gets upstreamed.

INLINE COMMENTS

> server_decoration.cpp:291
> +    Q_ASSERT(d->serversidedecoration.isValid());
> +    if(wl_proxy_get_version(d->serversidedecoration) < ORG_KDE_KWIN_SERVER_DECORATION_SET_PALETTE_SINCE_VERSION) {
> +        return;

nitpick: missing whitespace

> server_decoration_interface.h:147
> +     */
> +    void paletteChanged(const QString &paletteName);
> +

is it a paletteName or palettePath? IIRC we set complete paths?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171006/031ae9b5/attachment.html>