D8146: Don't try to override label heights - PlasmaComponents

[David Edmundson]

davidedmundson added a comment.


  I do hold a personal vendetta against this line, so I wish I could approve it.
  
  But, unlike the QQC2 change, PlasmaComponents.Label is pre-existing and used /everywhere/ . Not just within Plasma, but in literally every applet in the KDE store.
  
  I don't think it's possible to safely check there are no visual regressions.
  
  Note that PlasmaComponents3 (which is QQC2) does *not* have this line. 
  All of Plasma will be porting to that over the following months, and because it'll be one piece at a time is a lot easier to inspect.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8146

To: nicolasfella, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171004/18a30a93/attachment.html>