D9053: Migrate powerdevil keyboard shortcuts

David Edmundson noreply at phabricator.kde.org
Wed Nov 29 14:20:08 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Powerdevil "faked" that it's name was "kded5" presumably as a way to
  keep user's keyboard shortcuts without having to write a kconf_update
  script.
  
  It then tried setting the component name to "power management".
  This fails because immediately after it does so, kscreen (which has the component name kded5
  because it is in kded5) automatically changes the name back to "KDE Daemon".
  
  This means two things:
  
  - the shortcuts don't end up under their own "power management" section
  
  in system settings properly.
  
  - kglobalaccel5 on every startup thinks that the locale is changed (as
  
  a component has changed name) and does some complex heavy writing which we don't want.
  
  This patch moves everything to their own component, and provides a
  kconf_update script to move shortcuts.

TEST PLAN
  Confirmed shortcuts moved
  Confirmed we have our own "Power Management" section in systemsettings global shortcuts
  No more writing on starting kglobalaccel5
  
  I'd be grateful if someone else could confirm that migration works correctly. Migration is hard to re-test.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9053

AFFECTED FILES
  CMakeLists.txt
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/actions/bundled/handlebuttonevents.cpp
  daemon/actions/bundled/keyboardbrightnesscontrol.cpp
  kconf_update/CMakeLists.txt
  kconf_update/powerdevil_move_shortcuts.upd

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171129/12ca1ff1/attachment.html>


More information about the Plasma-devel mailing list