D9037: use desktop file actions instead of global shortcuts

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Nov 28 17:09:27 UTC 2017


apol added a comment.


  Looks cool!

INLINE COMMENTS

> main.cpp:94
>      View view;
> -    view.setVisible(false);
> +    const QString query = parser.positionalArguments().isEmpty() ? QString() : parser.positionalArguments().first();
> +    if (parser.isSet(clipboardOption)) {

You can do `const QString query = parser.positionalArguments().value(0);`

> main.cpp:108
> +        parser.parse(arguments);
> +        const QString query = parser.positionalArguments().isEmpty() ? QString() : parser.positionalArguments().first();
> +

^ `value(0)`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9037

To: mart, #plasma
Cc: apol, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171128/7d63c265/attachment.html>


More information about the Plasma-devel mailing list