D9032: [ResultDelegate] Get rid of Globals.js

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Nov 28 11:58:57 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This file contains a couple of constants but isn't (and cannot be as it's using `units`) marked `pragma library` causing an instance of this file being created for every delegate created which I think is not worth the overhead.

TEST PLAN
  KRunner and search plasmoid still looks fine, speeds up delegate creation and reducses ram consumption.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D9032

AFFECTED FILES
  lib/qml/ResultDelegate.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171128/9df1a647/attachment.html>


More information about the Plasma-devel mailing list