D8641: FormLayout

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in FormLayout.qml:113
> Flat mode:
> 
> main page of current mouse KCM:
> button order, icons.

Is this done?

> mart wrote in FormLayout.qml:121
> I tried that, but it messes with the gridlayout size hints and then i get the whole layout aligned at the right of the parent instead of the left

I think you'll need to try again.

Have you tested this code with a really really long label?

> FormLayout.qml:152-153
> +            implicitWidth: item.implicitWidth
> +            Layout.preferredWidth: item.Layout.preferredWidth
> +            Layout.preferredHeight: Math.max(item.Layout.preferredHeight, item.implicitHeight)
> +

I left a comment in my very first review of this!

Stil not addressed.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein, davidedmundson
Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171128/6f025cbb/attachment.html>