D8641: FormLayout

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> hein wrote in FormLayout.qml:66
> Doesn't Kirigami have wideMode logic somewhere else too?

yes, they are in some controls, independent from each other

> hein wrote in FormLayout.qml:114
> Isn't this going to cause tons of ReferenceErrors without "x in y" style checks?

what's x in y?

> hein wrote in mnemonicattached.h:162
> This can go with https://phabricator.kde.org/D8827, right?

no, mnemonics support is here, https://phabricator.kde.org/D8827 is the part in qqc2-desktop-style, another repo

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein, davidedmundson
Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171127/8c16b925/attachment.html>