D6764: Add font size setting to the digital clock plasmoid

[David Edmundson]

davidedmundson added a comment.


  If its good, sure. 
  If its simpler because it doesn't do all the things, then no.
  
  It's important to know why some things are done the way they were. Otherwise we just go round in circles fixing the reintroducing bugs.
  
  Like there's the implicit size hint being fixed so that if you use a font where "1" is thinner than "0" the clock doesn't jump contents about.
  
  Yours doesn't seem to have that.
  
  The other horrific monster in the current code is using the user's locale but disabling seconds.

REVISION DETAIL
  https://phabricator.kde.org/D6764

To: januz, #plasma, #vdg
Cc: IlyaBizyaev, davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171127/9ad1220d/attachment.html>