D8692: QML mouse cursor KCM and components

Eike Hein noreply at phabricator.kde.org
Thu Nov 23 14:26:13 UTC 2017


hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmcursortheme.cpp:150
> +    emit selectedThemeRowChanged();
> +    setNeedsSave(true);
> +    updateSizeComboBox();

Incorrect Apply button management

> kcmcursortheme.cpp:550
> +
> +    if (themeDirs.isEmpty())
> +        return false;

Coding style (many other places)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8692

To: mart, #plasma, hein
Cc: hein, davidedmundson, aspotashev, januz, ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171123/97b0cf24/attachment.html>


More information about the Plasma-devel mailing list