D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[Eike Hein]

hein marked 3 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:69
> "Task Manager notification: [checkbox] Enable Task Manager notification" a bit redundant and overly wordy. How about the following?
> 
> "Task Manager notification: [checkbox]"
> or
> "[checkbox] Enable Task Manager notification"
> 
> Paging @abetts for better ideas. :)

Will do former.

> davidedmundson wrote in main.qml:87
> once the user clicks the spinbox this binding will break.
> 
> When defaults is clicked, how does this update?

> When defaults is clicked, how does this update?

After fixing the binding bug: Via kcm.* signal emission, defaults() calls the setters which emit as needed.

> davidedmundson wrote in main.qml:88
> you might want to see valueModified

valueModified is new in Qt Quick Controls 2.2 (Qt 5.9) and I can't import that because of versioning conflicts with the imports in Kirigami. There are ways to hack around this but they're too awful.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8911

To: hein, #plasma, mart, abetts
Cc: ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171121/0d80d63d/attachment.html>