D8850: Support drag and drop between shared folder view containments

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> foldermodel.cpp:1126
> +                // the targetUrl file:// path to a desktop:/ path for mapping
> +                auto destPath = dropTargetUrl.path();
> +                auto filePath = targetUrl.path();

don't we need to check something like `targetUrl.toString().startsWith(dropTargetUrl.toString())` like above? I.e. including schema and so forth? This could otherwise match for `file://foo/bar` vs. `sftp://host/foo/bar`, no?

REVISION DETAIL
  https://phabricator.kde.org/D8850

To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171120/b1572031/attachment.html>