D8787: Fix PWD dialog
Kees vd Broek
noreply at phabricator.kde.org
Mon Nov 20 11:06:50 UTC 2017
cryptodude added a comment.
Updated to fix the issues.
The leading space was intended, indeed. It makes things look a bit nicer.
I also clarified the description, and as to the question if its still valuable.
The main change is that the original code was intended to not close the password dialog (as Ivan stated on bugs.kde) when an error occurred, but it does and people got confused when nothing happened. This patch make the intended behaviour actually work.
It may be nice to make the errors from the backends more legible and understandable to end-users, but I think that is a separate issue.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8787
To: cryptodude, #plasma, ivan
Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171120/2af6d528/attachment.html>
More information about the Plasma-devel
mailing list