D8850: WIP: support drag and drop between shared folder view containments

[Andras Mantia]

amantia added inline comments.

INLINE COMMENTS

> mwolff wrote in positionertest.cpp:219
> second? this is the first and only one in this test, no?

There is one coming from init() (m_folderModel)

> mwolff wrote in positionertest.cpp:229
> `QVERIFY` the wait, also below

Changed, the rest is actually not needed (no folder parsing is performed, just the filter changes)

> mwolff wrote in positionertest.cpp:232
> why not use hashes here too, then you can compare those below directly without having to convert the returned hash to a map first?

Right, I will change, makes sense. The original idea for the map was that I can more easily read that as it is sorted.

> mwolff wrote in positionertest.h:58
> could be a free function, no need to make this a member

I removed it.

> mwolff wrote in positioner.cpp:28
> do we still need this? I don't think so - I added this only for debugging purposes. should probably be part of a unit test now

I was wondering about it, especially that I don't like asserts :) I will remove them.

> mwolff wrote in positioner.cpp:461
> should also be removed and covered by a unit test instead I think

Ok.

> mwolff wrote in positioner.cpp:738
> this may be obsoleted by now, can you check whether it's still required?

I think it is still needed, but I will check.

REVISION DETAIL
  https://phabricator.kde.org/D8850

To: amantia, mwolff
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171120/dc7f633d/attachment.html>