D8888: Fix race condition with libinput events on startup

[Fabian Vogt]

fvogt added a comment.


  Should this go into Plasma/5.11 as well?

INLINE COMMENTS

> anthonyfieroni wrote in input.cpp:1734-1738
> Doesn't it to be in setup?
> 
>   void Connection::setup(QObject *to)
>   {
>       connect(this, &LibInput::Connection::eventsRead, to, [this]() { processEvents(); }, Qt::QueuedConnection);
>       QMetaObject::invokeMethod(this, "doSetup", Qt::QueuedConnection);
>   }
> 
> Caller should be
> 
>   conn->setup(this);
> 
> Otherwise it looks inconvenience, no?

IMO the connection should be made by the receiver, as it knows which threads are supposed to get which events.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8888

To: fvogt, #plasma, graesslin, davidedmundson
Cc: anthonyfieroni, ngraham, kwin, #kwin, plasma-devel, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171119/6d7590e6/attachment.html>