D8887: Fix leaking of FDs requested from logind

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.

REVISION SUMMARY
  The takeDevice method calls dup, but that syscall removes the O_CLOEXEC flag
  as a side-effect. This resulted in all child processes of kwin_wayland having
  an open file descriptor for those devices.

TEST PLAN
  Looked at the open FDs of the startplasma script. Before, all
  /dev/input/eventX files and /dev/dri/card0 were open. Now, none of those
  are part of /proc/PID/fd/

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8887

AFFECTED FILES
  logind.cpp

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171118/9790ae57/attachment.html>