D8598: FolderView: position files at drop event target position

Andras Mantia noreply at phabricator.kde.org
Fri Nov 17 08:51:38 UTC 2017


amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.


  Sorry, found two small issues :)

INLINE COMMENTS

> foldermodel.cpp:1076
> +        // remember drop target position for target URL and forget about the source URL
> +        connect(copyJob, &KIO::CopyJob::copyingDone, this, [this, map](KIO::Job *, const QUrl &src, const QUrl &targetUrl, const QDateTime &, bool, bool) {
> +            map(targetUrl);

Unused parameter src

> foldermodel.cpp:1079
> +        });
> +        connect(copyJob, &KIO::CopyJob::copyingLinkDone, this, [this, map](KIO::Job *, const QUrl &src, const QString &, const QUrl &targetUrl) {
> +            map(targetUrl);

Unused parameter src

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8598

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171117/d4162af5/attachment.html>


More information about the Plasma-devel mailing list