D8641: FormLayout

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in FormLayout.qml:45
> Use `Qt.callLater` (new in Qt 5.8) if you pass it an actual function (ie. not an inline one) it will compress subsequent calls to one: https://doc.qt.io/qt-5/qml-qtqml-qt.html#callLater-method
> 
> There's probably more places in the code where you could do this.

it's in frameworks, so i want to keep it still working as much as possible with 5.7

> broulik wrote in formlayoutattached.cpp:28
> This class does not have an `eventFilter`

ah, leftover when the mnemonics stuff was implemented here

> broulik wrote in formlayoutattached.h:56
> Unused, there's also no property.

other leftovers, sorry :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171116/d4a454d2/attachment.html>