D8798: Add xf86-input-libinput support for X11 mouse backend.

Nathaniel Graham noreply at phabricator.kde.org
Wed Nov 15 14:19:04 UTC 2017


ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> x11mousebackend.cpp:186
> +    m_supportedAccelerationProfiles.clear();
> +    bool adaptiveAvaiable = false;
> +    bool flatAvailable = false;

adaptiveAvaiable -> adaptiveAvailable (find-and-replace should take care of this, since there are many other uses of the misspelled term)

> x11mousebackend.cpp:235
> +    m_accelerationProfile = PROFILE_NONE;
> +    if (adaptiveAvaiable) {
> +        m_accelerationProfile = PROFILE_ADAPTIVE;

Is this supposed to be "if (adaptiveEnabled) {"

> x11mousebackend.cpp:237
> +        m_accelerationProfile = PROFILE_ADAPTIVE;
> +    } else if (flatAvailable) {
> +        m_accelerationProfile = PROFILE_FLAT;

Ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171115/160c34a3/attachment.html>


More information about the Plasma-devel mailing list