D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect
Martin Flöser
noreply at phabricator.kde.org
Tue Nov 14 19:18:34 UTC 2017
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Without Xwayland KWin starts so fast that the creation of the EffectFrame
triggers a crash in the Wayland integration as the KWin internal
connection isn't fully setup.
To workaround this crash the creation of the EffectFrame is delayed till
the first usage. It doesn't make sense to try to fix the actual crash as
it would require to defer the creation of all Effects.
TEST PLAN
New test case added which crashes without this fix.
REPOSITORY
R108 KWin
BRANCH
windowgeometry-delay-effectframe
REVISION DETAIL
https://phabricator.kde.org/D8821
AFFECTED FILES
autotests/integration/effects/CMakeLists.txt
autotests/integration/effects/windowgeometry_test.cpp
effects/windowgeometry/windowgeometry.cpp
effects/windowgeometry/windowgeometry.h
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171114/aaf8c1e2/attachment.html>
More information about the Plasma-devel
mailing list