D8641: FormLayout

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in FormLayout.qml:113
> I'd like it if we can make this on the desktop style look the same as QGroupBox looks in flat mode. Even if that means changing our QStyle.
> 
> Currently this means spanning both columns and then centre aligning.

any example how a groupbox looks in flat mode?

> davidedmundson wrote in FormLayout.qml:120
> why are we giving it a height if it's empty?

to recycle it as spacer if there is no text (instantiating a different item if there is no label would be both more complex and wouldn't allow for change at runtime)

> davidedmundson wrote in FormLayout.qml:121-123
> What's the rationale for this "if buddy.height > height *2" stuff?

when the item is very tall (for instance a columnlayout of other items such as is necessary for radiobuttons to work) to align the label at top instead at the middle, which looks weird

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171113/f7696c66/attachment.html>