D8779: Avoid hypothetical crash if output->init fails

David Edmundson noreply at phabricator.kde.org
Sun Nov 12 22:40:55 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  con->setOutput and crtc->setOutput  is called in Output::~Output so this
  is doing it twice redundantly.
  
  More importantly Output::~Output calls crtc->blank(), which means we
  need a valid CRTC object there.

TEST PLAN
  Compiles

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8779

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171112/5b321700/attachment.html>


More information about the Plasma-devel mailing list