D8735: revise the tab upload dialog to direct people at the kde store

Harald Sitter noreply at phabricator.kde.org
Thu Nov 9 12:12:50 UTC 2017


sitter created this revision.
sitter added reviewers: Plasma, jriddell.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  previously the dialog would ask users to mail John Tapsell who I think
  doesn't maintain ksysguard anymore, plus that was weirdly not scaling.
  instead we can simply publish it through the kde store (https://phabricator.kde.org/D8734).
  provide all pertinent information to do this.
  
  also
  
  - switch to xi18n and use markup tags instead of manual rich text
  - use KNS to retrieve the category name for the store so as to not hardcode it
  - assert that the KNS config has only one category to ensure this doesn't go randomly messed up in the future should multiple categories get used

TEST PLAN
  - create a new tab
  - file -> upload
  - dialog pops up
  - dialog has relevant information to actually publish the file

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8735

AFFECTED FILES
  gui/Workspace.cpp

To: sitter, #plasma, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171109/dc91b31d/attachment.html>


More information about the Plasma-devel mailing list