D8721: fix overlapping labels on systems with different window sizes

Harald Sitter noreply at phabricator.kde.org
Wed Nov 8 13:27:06 UTC 2017


sitter created this revision.
sitter added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  it is not quite clear to me why a Window may have a Y != 0 to begin with,
  but it happens and can in fact happen even though only uniform screens
  are attached (I suspect some GRUB resolution handover problem which for
  some reasons persists through modesetting, though that's really just a
  guess). So on a 1920x1080 screen  Window[0] can be 1024x768 with a Y
  such that it is centered on the effectively larger screen. While that is
  altogether insane we do handle window offsets when placing our Logo,
  relative to that we place our Spinner and relative to that we place
  the label offset. Previously we didn't take into account the Window offset
  when calculating the "scootyness" of the label offset (i.e. if the label
  would likely exceed the window it gets scooted around as to preserve
  readability) which resulted in us placing our offset entirely incorrectly
  (off by whatever the window y is).
  
  Easy fix: take the Window Y into account when checking for the need of
  scooting. This aligns the window frame expectations between Logo and
  label offset making it less likely to have text overlap when none is needed

REPOSITORY
  R526 Breeze theme for Plymouth

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D8721

AFFECTED FILES
  breeze/breeze.script.cmake

To: sitter, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171108/f019e320/attachment.html>


More information about the Plasma-devel mailing list