D8673: Sanitize signal handling in ksmserver

Jiří Paleček noreply at phabricator.kde.org
Mon Nov 6 23:44:30 UTC 2017


jpalecek added a comment.


  In https://phabricator.kde.org/D8673#164830, @davidedmundson wrote:
  
  > Do the sockets need closing in the destructor?
  
  
  Good point. I assumed the `KSMServer` instance is practically a singleton (being assigned to global `the_server` etc.) which is created only once during running of the process. In that case, the sockets would be destroyed anyway so I kind of cut that corner and left it be. It would certainly be cleaner to close them in the destructor.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8673

To: jpalecek, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171106/4fb09002/attachment.html>


More information about the Plasma-devel mailing list