D8661: Allow a cross-process check for same applications

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Commit https://phabricator.kde.org/R108:5d9027b110be7510a75daa789402b83c106a4164 introduced a regression in TabBox by using the generic
  framework inside KWin to test for same application. What I did not
  consider was that the code in TabBox was "broken by design". It didn't
  use the generic check as that is too strict and considers windows from
  different processes as not belonging to the same application. But this
  is not wanted in the case of TabBox.
  
  On the other hand the change itself is an improvement to also support
  Wayland in a better way and not have special handling situations. Thus
  just reverting would not help.
  
  Instead this change addresses the problem by extending the internal API
  and to allow more adjustements. So far there was already an
  "active_hack" boolean flag. This is extended to proper flags with an
  additional flag to allow cross application checks.
  
  The checks in Client which would filter out different applications check
  for this flag and are skipped if set. In addition ShellClient also adds
  support for this flag and compares for the desktop file name.
  
  Thus we get in TabBox the same behavior as before with the advantage of
  having a better shared code base working on both X11 and Wayland.
  
  BUG: 386043
  FIXED-IN: 5.11.3

TEST PLAN
  Started two kwrite processes on X11, clicked new in one of them,
  used Alt+` and verified that there are three windows shown.

REPOSITORY
  R108 KWin

BRANCH
  belong-to-same-application-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8661

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  activation.cpp
  client.cpp
  client.h
  group.cpp
  shell_client.cpp
  shell_client.h
  tabbox/tabbox.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171105/ba6e3a07/attachment.html>