D8493: Make Folder View screen aware

[Andras Mantia]

amantia added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in foldermodel.cpp:163-164
> When QObject dies it's disconnected to all signal/slots. In this case if you want to not notify FolderModel you can use
> 
>   m_screenMapper->disconnect(this);

Yes, I know, indeed this might be more clear.

> anthonyfieroni wrote in screenmapper.cpp:32-36
> When you use singleton it's better to make variable construction in one line
> 
>   static ScreenMapper *s_instance = new ScreenMapper();
>   return s_instance;
> 
> or
> 
>   static ScreenMapper s_instance;
>   return &s_instance;
> 
> In this way you don't have unwanted check for creation and variable at class scope.

Ok, although I don't see this commonly used in KDE (or Qt). If you really want, I can change it of course.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171104/af2ae2fb/attachment.html>