D8627: [platforms/drm] Properly adjust cursor position on a rotated output

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in drm_output.cpp:109
> > for all variants of scaled, rotated and differently positioned outputs.
> 
> "by all variants of rotated" do you mean just this one?

I meant, that I rotated the screen by 180 degree, scaled it, repositioned it, did the same for the other screen. On the system I test I can only rotate by 180 degrees, so the other variants will follow once I'm able to actually rotate by 90 degrees (I hope my yoga allows that).

Sorry that was not clearly formulated.

> davidedmundson wrote in drm_output.cpp:116
> I'm 95% sure you need to rotate your softwareCursorHotspot.
> 
> It's something hard to see, becuase you'll only be off by a few px.
> 
> The only reason I'm not scaling the offset is because we're not scaling the contents of the cursor planet (which is arguably wrong), you are rotating it.

I didn't include that part on purpose. Currently it doesn't make sense yet as the cursor itself is not yet rotated, so it's clearly wrong. Whether it's rotated or not.

To actually get this right we first need to add support for rotating the cursor image (I already have figured out how to do it, but requires some refactoring).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8627

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171102/6643d9f4/attachment.html>