D8006: Add edit button to desktop theme

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kcm.cpp:69
> +
> +    m_haveThemeExplorerInstalled = KService::serviceByDesktopName(QStringLiteral("org.kde.plasma.themeexplorer"));
>  }

Wouldn't it be better to just do `QStandardPaths::findExecutable("plasmathemeexplorer")`? This way we don't need a new dependency

> kcm.cpp:257
> +{
> +    KRun::runCommand(QStringLiteral("plasmathemeexplorer -t ") % theme, nullptr);
> +}

QProcess?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8006

To: davidedmundson, #plasma
Cc: apol, abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171102/eaf8aa9b/attachment-0001.html>