D8617: Folder View previews dialogue: Improve visual layout

Jonathan Marten noreply at phabricator.kde.org
Thu Nov 2 13:14:14 UTC 2017


marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is the small dialogue that is summoned by the "More Preview Options" button on the "Icons" page.  Previously:
  
  F5466090: folderview-properties-preview_BEFORE.png <https://phabricator.kde.org/F5466090>
  
  there was no margin around either the scrolling list of the dialogue buttons.  The revised layout:
  
  F5466093: folderview-properties-preview_AFTER.png <https://phabricator.kde.org/F5466093>
  
  has margins added where appropriate.
  
  The background colour of the scroll view is forced to the standard system background.  This does not appear to be an issue with the Breeze style, but with older styles the scroll view background seems to be use the window background colour rather than the configured view background colour.

TEST PLAN
  Built plasma-desktop with this change, checked appearance and operation of the configuration dialogue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8617

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171102/e936583d/attachment.html>


More information about the Plasma-devel mailing list