D8597: Cleanup: use temp variables instead of querying properties repeatedly

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Nov 1 17:08:03 UTC 2017


broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> foldermodel.cpp:981
>  
> -    QPoint pos;
> -    pos.setX(dropEvent->property("x").toInt());
> -    pos.setY(dropEvent->property("y").toInt());
> -
> +    QPoint pos = {x, y};
>      pos = target->mapToScene(pos).toPoint();

`QPoint pos(x, y);`?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  wip/lim-2

REVISION DETAIL
  https://phabricator.kde.org/D8597

To: mwolff, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171101/b03f2d96/attachment.html>


More information about the Plasma-devel mailing list