D8596: Fix memory leak in FolderModel::drop

Milian Wolff noreply at phabricator.kde.org
Wed Nov 1 16:50:18 UTC 2017


mwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When handling a drop event, a drop job was created and a
  Qt signal/slot connection created. This connection was only
  freed once the model gets destroyed, which is, for the common case,
  the end of the plasma session. As such, triggering many drop
  actions on a folder model would essentially leak memory.
  
  To prevent this, clear the connection when the drop job is destroyed.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  wip/lim-2

REVISION DETAIL
  https://phabricator.kde.org/D8596

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mwolff
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171101/c2a739c3/attachment.html>


More information about the Plasma-devel mailing list