D8493: Make Folder View screen aware

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> amantia wrote in foldermodel.cpp:1671
> Done, although the screenmapper will never change.

an assert would be valid in such a scenario

> amantia wrote in foldermodel.cpp:1704
> From my understanding, this setAppletInterface is called only once when the applet is created. I can do the disconnect, but imo that only pollutes the code.

then add an `Q_ASSERT(!m_appletInterface)`, this documents your intent and does not pollute the code

> amantia wrote in screenmapper.cpp:97
> Done, but as in the other cases, this should be called only once.

use an assert then

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol
Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171101/67e4ca9d/attachment.html>