D8493: Make Folder View screen aware

[Andras Mantia]

amantia added inline comments.

INLINE COMMENTS

> mwolff wrote in foldermodel.cpp:1671
> missing disconnect on the old mapper for the invalidate filter

Done, although the screenmapper will never change.

> mwolff wrote in foldermodel.cpp:1704
> when the interface changes, don't you need to disconnect the old containment here?

>From my understanding, this setAppletInterface is called only once when the applet is created. I can do the disconnect, but imo that only pollutes the code.

> mwolff wrote in screenmapper.cpp:90
> `return m_firstScreen`, no? faster, and your code would crash if there is no screen available

Couldn't use that in this version, but in the updated one I fixed, so now m_firstScreen is always correct and could just return it.

> mwolff wrote in screenmapper.cpp:97
> missing disconnect on old m_corona, if valid

Done, but as in the other cases, this should be called only once.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol
Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171101/bde1869b/attachment-0001.html>