D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added inline comments.

INLINE COMMENTS

> davidedmundson wrote in drm_buffer.cpp:131
> If it's deferred it means someone else is doing the gbm_surface_release.
> 
> But we still need to set m_bo to nullptr. Otherwise it's potentially left dangling here after the RemoteAccessManager has deleted it.
> 
> (Alternately: if we changed DrmObjectPlane to store the buffers as QSharedPointers we could just keep a reference to the DrmBuffer in the RemoteAccessManager, which would be IMHO cleaner than doing low level GBM stuff there and having the data released in one of two places. I'll look into that)

I rewrote this part since this change and it doesn't touch buffers now, if you want to take a look at it prior to my resubmission, it's there:

https://gitlab.com/Kanedias/kwin/commit/9535f36bd09f8834be3773f25bf2075a720ba1c4

> davidedmundson wrote in remoteaccess_manager.h:49-50
> what's this signal for?

Forgot to get rid of it, thanks

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170530/dcdd5a73/attachment.html>