D5928: Introducing Night Color - KWin's native blue light filter at nighttime

[Roman Gilg]

subdiff added a comment.


  In https://phabricator.kde.org/D5928#112368, @cfeck wrote:
  
  > First, the difference between "color management" and "color correction" is that color correction is only one step in the color management workflow. KWin would need (again) be able to apply color correction to take part in the color management workflow. As such, the terms color correction and color management can be used interchangeably in the context of KWin discussion.
  >
  > Gamma correction (as implemented by the hardware LUTs) cannot be used for color correction, because it lacks the cross-component modifications computed by the 3x3 matrix or the 3D LUT.
  >
  > The term "gamma correction" has been used since decades in the context of video cards, even if they are not only used to apply gamma correction, but also brigthness/contrast adjustments, color inversion effects, and temperature adjustments.
  
  
  Thanks for the explanation in your own words, but there has to be some misunderstanding. I wanted to see a quote from a second source besides you where it says:
  
  "We define Color Correction as..." or "Color Correction is..."
  and
  "We define Gamma Correction as..." or "Gamma Correction is..."
  
  Because currently to me it seems Wikipedia and you have different notions of what color correction is supposed to be (also other sources disagree: https://creativepro.com/color-management-not-color-correction/). But I'll leave this naming discussion for now aside, because it's not really important. I would still say color correction is the right term to call it, since in the end the perceived result is a change of color temperature or color balance and not one of the overall gamma in particular. Since the old stuff, which got called color correction back then, has been removed and and when I look at the code likely won't come back, I also don't see a problem with naming my stuff that way. The old stuff should've been called differently anyway according to the above link. But I'll leave the naming decision to Martin, if this is ok with him.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5928

To: subdiff, #kwin
Cc: cfeck, graesslin, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170529/762eb378/attachment.html>