D5976: Remove code to poll the udev events for brightness

Bhushan Shah noreply at phabricator.kde.org
Fri May 26 15:53:09 UTC 2017


bshah created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This code watches the device in the sysfs for changes, if device is
  changed it reads the brightness again and updates it.
  
  However that is,
  
  a) Redundant: as if we update the brightness we already know what
  brightness we set it to
  
  b) Covers corner case: If something other then powerdevil updates the
  brightness, this will update the internal brightness code accordingly
  
  So, lets remove this extra overhead of going through udev/uevent and
  make things bit more simpler

TEST PLAN
  tested brightness control using keyboard, battery monitor

REPOSITORY
  R122 Powerdevil

BRANCH
  remove-udevqt

REVISION DETAIL
  https://phabricator.kde.org/D5976

AFFECTED FILES
  CMakeLists.txt
  cmake/FindUDev.cmake
  daemon/CMakeLists.txt
  daemon/backends/CMakeLists.txt
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h
  daemon/backends/upower/udevqt.h
  daemon/backends/upower/udevqt_p.h
  daemon/backends/upower/udevqtclient.cpp
  daemon/backends/upower/udevqtclient.h
  daemon/backends/upower/udevqtdevice.cpp
  daemon/backends/upower/udevqtdevice.h

To: bshah, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170526/d484bcee/attachment-0001.html>


More information about the Plasma-devel mailing list