D5950: Implement the new panel icon size ceiling also for Activities.
Marco Martin
noreply at phabricator.kde.org
Wed May 24 09:01:50 UTC 2017
mart reopened this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> main.qml:31
>
> - Layout.minimumWidth: units.iconSizes.small
> - Layout.minimumHeight: units.iconSizes.small
> + readonly property bool inPanel: (plasmoid.location == PlasmaCore.Types.TopEdge
> + || plasmoid.location == PlasmaCore.Types.RightEdge
to detect if this is in a panel was intended from the beginning the formfactor, not the location
> main.qml:37
> + Layout.maximumWidth: inPanel ? units.iconSizeHints.panel : -1
> + Layout.maximumHeight: inPanel ? units.iconSizeHints.panel : -1
>
this will break fitts law on an horizontal panel, as mouse wouldn't work on screen edge?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5950
To: hein, #plasma, mart, broulik
Cc: mvourlakos, ivan, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170524/9323beea/attachment.html>
More information about the Plasma-devel
mailing list